Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ImplementAbstractMethodsHintError #3734

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Improve ImplementAbstractMethodsHintError #3734

merged 1 commit into from
Mar 9, 2022

Conversation

junichi11
Copy link
Member

  • Sort method elements to get the same result

@junichi11
Improve ImplementAbstractMethodsHintError
b6d57f2 
- Sort method elements to get the same result
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 9, 2022
@junichi11 junichi11 added this to the NB14 milestone Mar 9, 2022
@junichi11 junichi11 requested a review from tmysik March 9, 2022 03:53
@junichi11 junichi11 mentioned this pull request Mar 9, 2022
Merged
@oyarzun
Copy link
Contributor

oyarzun commented Mar 9, 2022

@junichi11 looks good.

    [junit] Testsuite: org.netbeans.modules.php.editor.verification.ImplementAbstractMethodsHintErrorTest
    [junit] Mar 09, 2022 9:10:06 AM org.netbeans.modules.masterfs.watcher.Watcher getNotifierForPlatform
    [junit] INFO: Native file watcher is disabled
    [junit] Mar 09, 2022 9:10:07 AM org.netbeans.modules.settings.RecognizeInstanceObjects$MSL <clinit>
    [junit] WARNING: Not listening on module system
    [junit] Mar 09, 2022 9:10:09 AM org.netbeans.modules.php.editor.parser.GSFPHPParser <clinit>
    [junit] INFO: Parsing of big PHP files enabled: false (max size: 5,000,000)

@junichi11
Copy link
Member Author

@tmysik Thank you for your review!
@oyarzun Thank you for your verification!
Merging.

@junichi11 junichi11 merged commit 30b1d7c into apache:master Mar 9, 2022
@junichi11 junichi11 deleted the php-improve-implement-abstract-methods-hint-error branch March 9, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@junichi11 @oyarzun @tmysik