[NETBEANS-3730] Add simple code completion for Spock test framework #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @ppisl, you can link to issues on the right side under "Development", this will close them automatically post integration -> |
2 tasks
sdedic
reviewed
Mar 18, 2022
...oovy.editor/src/org/netbeans/modules/groovy/editor/completion/SpockBlockNamesCompletion.java
Show resolved
Hide resolved
sdedic
requested changes
Mar 18, 2022
...ovy.editor/src/org/netbeans/modules/groovy/editor/completion/SpockMethodParamCompletion.java
Show resolved
Hide resolved
|
|
||
| for (int i = 1; i < parts.length; i++) { | ||
| String part = parts[i].trim(); | ||
| if (!part.isEmpty()) { |
There was a problem hiding this comment.
Since the name is already matched by a regex in split() ... wouldn't it be faster to iterate using Pattern.compile("#\\p{Alpha}[\\p{Alnum}$_]*)[. ]?*).matcher(name) ?
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/SpockUtils.java
Show resolved
Hide resolved
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/SpockUtils.java
Show resolved
Hide resolved
sdedic
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented issue #3730.
Added basic code completion for Spock test framework: