Fix maven daemon detection on windows platform #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
reviewed
Mar 12, 2022
Comment on lines
47
to
48
| String mavenDaemonSuffixDetection = Utilities.isWindows() ? ".cmd" : ""; | ||
| String ex = Files.exists(Paths.get(mavenHome.getPath(), "bin", "mvnd" + mavenDaemonSuffixDetection)) ? "mvnd" : "mvn"; //NOI18N |
There was a problem hiding this comment.
i think we should probe here for mvnd.exe instead of .cmd because mvnd is a binary. It is not super important but it would make it symmetrical.
Thanks for fixing this for windows btw. Feel free to force push.
There was a problem hiding this comment.
Change done :)
mbien
approved these changes
Mar 12, 2022
|
Looks also sane to me. Lets get this in. |
|
Ah - minimal nitpick: @philippefichet could you please squash the two commits into one? |
|
@matthiasblaesing squash is done ;) (sorry for the delay) |
|
After 4 tries, travis is also happy. Lets get this in. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "bin" folder of "mvnd-0.7.1-windows-amd64" (latest current release), the list of files is as follows:
I take the liberty of adding the suffix ".cmd" when detecting under windows only