Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Commons-Net from 3.6 to 3.8.0 #3775

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Upgrade Commons-Net from 3.6 to 3.8.0 #3775

merged 3 commits into from
Mar 28, 2022

Conversation

pepness
Copy link
Member

@pepness pepness commented Mar 13, 2022 •
edited

Library Notes:

  • Reduced size by 1 KB
  • 19 Bug fixes
  • 13 New Features
  • 17 Improvements

NetBeans Notes:

  • Remove usage of commons.net.util.Base64 in favor of JDK java.util.Base64 in module ide/hudson.ui

Testing:

  • Full build done
  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of unit tests for modules ide/hudson.ui and php.project (the one that use this library)
  • Checked the jar is in {nb_install}/ide/modules/ext/commons-net-3.8.0

Web Page
Release Notes

@pepness pepness added the Upgrade Library Library (Dependency) Upgrade label Mar 13, 2022
@pepness pepness added this to the NB14 milestone Mar 13, 2022
@pepness pepness self-assigned this Mar 13, 2022
@matthiasblaesing
Copy link
Contributor

I would remove the unittest and remove the dependency from hudson.ui. At least at the use site a normal urlconnection is used.

@matthiasblaesing
Copy link
Contributor

I saw the update, but the dependency of hudson.ui on commons-net is still there. Is this intended?

@pepness
Copy link
Member Author

pepness commented Mar 27, 2022

You are right, I forgot to remove the dependency from the project.xml file

matthiasblaesing
matthiasblaesing approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you. Please squash before merge.

@pepness pepness merged commit d2f6617 into apache:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees

@pepness pepness

Labels
Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Milestone
NB14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pepness @matthiasblaesing