Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Apache Maven from 3.8.4 to 3.8.5 #3796

Merged
merged 1 commit into from Mar 26, 2022
Merged

Conversation

pepness
Copy link
Member

@pepness pepness commented Mar 16, 2022

Based on PR-3328

Library Notes:

  • 15 Bug fixes
  • 2 New Features
  • 7 Improvements
  • 3 Dependencies upgrades

Testing:

  • Full build done
  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of unit tests for module java/maven.embedder
  • Checked the file is in {nb_all}/java/maven/
  • Checked the option Options > Java > Maven Home > Bundled is version 3.8.5

Web Page
Release Notes

@pepness pepness added Upgrade Library Library (Dependency) Upgrade Maven [ci] enable "build tools" tests labels Mar 16, 2022
@pepness pepness added this to the NB14 milestone Mar 16, 2022
@pepness pepness requested a review from ebarboni March 16, 2022 22:29
@pepness pepness self-assigned this Mar 16, 2022
@ebarboni
Copy link
Contributor

Hi @pepness maybe we should wait a bit for feedback in maven ml. 3.8.3 was released but issues were detected not IDE friendly and they did a 3.8.4.

@neilcsmith-net
Copy link
Member

Possibly keep an eye on eclipse-m2e/m2e-core#602 which is merged recently. They had (and reported) the same issue we had with 3.8.3. I'd be tempted to merge soon so we have a chance to revert before NB14 if problems show up though.

@ebarboni
Copy link
Contributor

sure didn't think this way. lets anticipate and merge

@pepness pepness merged commit ebb8086 into apache:master Mar 26, 2022
@dyorgio
Copy link
Contributor

dyorgio commented Jul 5, 2022

Guys, I had a lot of problems with transitive deps on sub-projects.
All regressed with maven 3.8.6:

https://issues.apache.org/jira/browse/MNG-7493

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12351556

@neilcsmith-net
Copy link
Member

Thanks @dyorgio Was about to ask you to open an issue, but noticed you already have - #4332

@ebarboni
Copy link
Contributor

ebarboni commented Jul 5, 2022

@dyorgio you mean we should move to 3.8.6 ?

@dyorgio
Copy link
Contributor

dyorgio commented Jul 5, 2022

@ebarboni It solved my problems 😇, I really don't know if not will bring new ones 😝

@ebarboni
Copy link
Contributor

ebarboni commented Jul 5, 2022

will setup a pr for 3.8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maven [ci] enable "build tools" tests Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants