cleanup Byte & Short object constructors #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradWalker
added
Code cleanup
Java
…tain primitives than it is to invoke the object constructor. This change cleans up Byte & Short for this. Tests have been left untouched because we expressly want to do handle the boxing in each particular test.
BradWalker
force-pushed
the
cleanup_byte-short_primitives
branch
from
cee40a0
to
24dfe07
Compare
|
@BradWalker you probably mean NB14 as milestone :) I fixed it on the other PR already. |
Hey @mbien , does that mean you intend to integrate the change or should I? |
NB13 is already released. I only wanted to say that we shouldn't put NB13 as milestones on PRs anymore. Changes look good on first glance though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more efficient to allow the VM to manage the auto-boxing of certain primitives than it is to invoke the
object constructor.
This change cleans up Byte & Short for this.
Tests have been left untouched because we expressly want to handle the boxing in each particular test.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.