Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-313] Remove bootstrap.css from css.model #384

Merged
merged 22 commits into from Jan 23, 2018
Merged

[NETBEANS-313] Remove bootstrap.css from css.model #384

merged 22 commits into from Jan 23, 2018

Conversation

geertjanw
Copy link
Member

No description provided.

@geertjanw
Copy link
Member Author

Will squash once approved.

@geertjanw geertjanw merged commit 2be199e into apache:master Jan 23, 2018
@matthiasblaesing
Copy link
Contributor

Why was this merged? According to the legal FAQ:
https://www.apache.org/legal/resolved.html#category-a
MIT is whitelisted and the license terms are perfectly met. The license must stay in place and the unittests are only delivered in source - there is nothing to remove here.

@geertjanw
Copy link
Member Author

geertjanw commented Jan 26, 2018

I understand your point. However, questions have been asked about[1] this file and it seems strange to have bootstrap.css there, especially for one test only, so in this particular case, certainly not as a general rule, thought it best just to remove it.

[1]https://lists.apache.org/thread.html/5fdb996c8b25e5c48c47e4eca3942b656f690694d767d795524cc960@%3Cgeneral.incubator.apache.org%3E

@matthiasblaesing
Copy link
Contributor

Thanks for explaining - I agree with the assessment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants