Invoke arbitrary action from vscode #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
approved these changes
Mar 24, 2022
| private CompletableFuture<Object> invokeAction(NbCodeLanguageClient client, String category, String aid, List<Object> arguments) { | ||
| String path = "Actions/" + category + "/" + aid.replace('.', '-') + ".instance"; //NOI18N | ||
| FileObject config = FileUtil.getConfigFile(path); | ||
| String contextType = (String) config.getAttribute("type"); //NOI18N |
There was a problem hiding this comment.
Please write a test for this new API/behavior.
sdedic
reviewed
Mar 25, 2022
| String contextType = (String) config.getAttribute("type"); //NOI18N | ||
| try { | ||
| Class<?> clazz = Thread.currentThread().getContextClassLoader().loadClass(contextType); | ||
| Object context = gson.fromJson(gson.toJson(arguments.get(0)), clazz); |
There was a problem hiding this comment.
Q: this deserializes the 1st argument, which was deserialized at line ~97 as JSONObject, in an attempt to read inputs like { data : { id: <nodeId> } }. Does the code that deserializes a JSONObject / id behave "well" when it is fed with a typed parameter (other node-based actions) ?
There was a problem hiding this comment.
In case the new method invokeAction() is called the first argument doesn't contain input you mention above (data) as it is not called from tree view. It is expected to contain fields for a action type to deserialise properly
sdedic
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding possibility to invoke arbitrary action from vscode. Any action registered in
java/java.lsp.server/nbcode/integration/src/org/netbeans/modules/nbcode/integration/layer.xmlcan be called as a vscode command:vscode.commands.executeCommand('nbls:<Category>:<actionId>', <context>);. Context will be converted to Action type defined in layer.