Fix KeyRing issues #3869
Merged
Fix KeyRing issues #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 25, 2022
…cting disable it The code path in GnomeLibSecretProvider#enabled relies on RuntimeException to be thrown in case of errors. Before this change errors from libsecret were written to the messages.log, but still allowed NetBeans to enable libsecret to be activated as password wallet. Closes: apache#3579
The application names for the Gnome Keyring and LibSecret integrations are derived from the name of the application. That name contains the release version, so the passwords are lost on each update. Instead of deriving the name from the application name, GnomeKeyring and LibSecret are brought in line with the existing implementation of KWallet and mac OS, where the name is hardcoded. As the names for GnomeKeyring and LibSecret have to be change at least once more, they are unified to the KWallet name (which might be accessed by LibSecret) Closes: apache#3702
matthiasblaesing
force-pushed
the
keyring_optimization
branch
from
95d1974
to
5f13dde
Compare
|
Both fixed issues were verified (one tested by myself, the second by the reporter), unittests are green I did a self-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.