Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case when the connection name is not known before wallet download #3905

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

jhorvath
Copy link
Contributor

In case the connection name is not known before the DB Wallet is downloaded, parse wallet's tnsnames.ora and take one from there.

@jhorvath jhorvath changed the title Handle the case when the connection name is no known before wallet download Handle the case when the connection name is not known before wallet download Mar 31, 2022
@mbien
Copy link
Member

mbien commented Mar 31, 2022

hmm. why can't the secondary jobs find the artifact in this PR. This never happened during testing.

looking at the first workflow run:
https://github.com/apache/netbeans/runs/5769887724?check_suite_focus=true

  1. base job uploaded successfully
  2. secondary jobs could download, however, the file was corrupted and extraction failed
  3. all secondary jobs failed, but the cleanup job removed the artifact successfully

All subsequent workflow runs fail with secondary jobs not finding any artifacts, despite the primary job getting a success msg after upload:
"Artifact build has been successfully uploaded!"

i have never seen something like that. might be a temp gh issue?

@mbien
Copy link
Member

mbien commented Mar 31, 2022

@jhorvath i deleted the complete workflow run. Could you do me a favor and force push into this PR to trigger a fresh run?

@jhorvath
Copy link
Contributor Author

@mbien It is pushed already, but just 3 checks are queued.

@mbien
Copy link
Member

mbien commented Mar 31, 2022

It is pushed already, but just 3 checks are queued.

@jhorvath it works like a pipeline now. Two primary jobs build, rest starts later after they succeed and use the artifact of the primary build for tests.

the summary shows a nice graph https://github.com/apache/netbeans/actions/runs/2071857027

anyway. Everything appears to be working fine now. This might just have been a weird anomaly. At least we know how to fix it if it happens again.

@jhorvath jhorvath merged commit 5a76982 into apache:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants