Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3898] Parameterize Tomcat startup/shutdown timeouts. #3915

Merged
merged 1 commit into from
Apr 2, 2022
Merged

[#3898] Parameterize Tomcat startup/shutdown timeouts. #3915

merged 1 commit into from
Apr 2, 2022

Conversation

peedeeboy
Copy link
Contributor

Closes: #3898 for jocelyn44

Adds Startup / Shutdown timeouts to the Tomcat server customizer.

image

@mbien mbien requested a review from lkishalmi April 2, 2022 03:46
@mbien mbien added this to the NB14 milestone Apr 2, 2022
lkishalmi
lkishalmi approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems somebody was in the mood!
Looks good. Thanks!

matthiasblaesing
matthiasblaesing approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me too

@matthiasblaesing matthiasblaesing merged commit f47ca71 into apache:master Apr 2, 2022
@jocelyn44
Copy link

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkishalmi lkishalmi lkishalmi approved these changes

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
NB14
Development

Successfully merging this pull request may close these issues.

Tomcat start delay hardcoded to 180s
5 participants
@peedeeboy @jocelyn44 @lkishalmi @matthiasblaesing @mbien