Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IDE defaults from NBLS distribution. #3930

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Apr 5, 2022

This is a very simple change - just removing ide/defaults module from NBLS distribution. The module contains shortcuts and color definitions, which are not needed at all in the headless case. But those definitions reference actual actions that might not be included and they print exceptions to log in various situations where the registrations are lazy-loaded.

@sdedic sdedic self-assigned this Apr 5, 2022
@sdedic sdedic requested a review from dbalek April 5, 2022 13:31
@sdedic sdedic added kind:bug Bug report or fix VSCode Extension [ci] enable VSCode Extension tests labels Apr 5, 2022
@sdedic sdedic merged commit 8e4a0b8 into apache:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Bug report or fix VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants