Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Minor bug fixes #3984

Merged
merged 6 commits into from
Apr 14, 2022
Merged

LSP: Minor bug fixes #3984

merged 6 commits into from
Apr 14, 2022

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Apr 13, 2022

  • Do not log by default errors from fallback handling of another errors
  • Do not produce CodeActions for cached diagnostics - crating a fix for a diagnostic that is no more valid (while diagnostic re-computation is still progress after a source modification) could lead to nasty errors reported

@dbalek dbalek added the LSP [ci] enable Language Server Protocol tests label Apr 13, 2022
@dbalek dbalek added this to the NB14 milestone Apr 13, 2022
@dbalek dbalek merged commit ff295f0 into apache:master Apr 14, 2022
@dbalek dbalek deleted the dbalek/minor-fixes branch April 14, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdedic sdedic sdedic approved these changes

@jlahoda jlahoda Awaiting requested review from jlahoda

@MartinBalin MartinBalin Awaiting requested review from MartinBalin

Assignees
No one assigned
Labels
LSP [ci] enable Language Server Protocol tests
Projects
None yet
Milestone
NB14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbalek @sdedic