Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3921] Correctly handling opens directive in package rename. #3993

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[3921] Correctly handling opens directive in package rename. #3993

merged 1 commit into from
Apr 19, 2022

Conversation

jlahoda
Copy link
Contributor

@jlahoda jlahoda commented Apr 17, 2022

When a package is renamed, reference to it in the opens directive is not renamed - fixed. See:
#3921

@jlahoda jlahoda added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Apr 17, 2022
@jlahoda jlahoda added this to the NB14 milestone Apr 17, 2022
@mbien mbien linked an issue Apr 17, 2022 that may be closed by this pull request
When package is renamed NB doesnt rename it in module-info opens section #3921
Closed
matthiasblaesing
matthiasblaesing approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert in the javac area, but the change brings the handling of opens in line with the existing exports handling, which makes sense to me. It is also protected by a unittest, that matches the error description. It would be good to merge this soon.

@matthiasblaesing
Copy link
Contributor

Lets get this in for NB14 (which is branched tomorrow)

@matthiasblaesing matthiasblaesing merged commit 14c9f20 into apache:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Milestone
NB14
Development

Successfully merging this pull request may close these issues.

When package is renamed NB doesnt rename it in module-info opens section
2 participants
@jlahoda @matthiasblaesing