Fix GradleReport Notification and potential NPE on Gradle earlier, than 6.8 #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
reviewed
Apr 17, 2022
...s-gradle-tooling/src/main/java/org/netbeans/modules/gradle/tooling/NbProjectInfoBuilder.java
Show resolved
Hide resolved
… earlier than version 6.8
lkishalmi
force-pushed
the
fix-gradle-report-notification
branch
from
4599599
to
d5ba709
Compare
sdedic
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My intention was to fix this notification, by adding an appropriate toString() method to GradleReport. Though it seems the project where I've got this was generating an NPE in LegacyProjectLoader. Which root cause was that, the recently introduced method call of getExternalVariant() was added only Gradle 6.8