Detect proxy issues and offer fixes. #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
reviewed
Apr 28, 2022
extide/gradle/src/org/netbeans/modules/gradle/problems/ChangeOrRemovePropertyResolver.java
Outdated
Show resolved
Hide resolved
extide/gradle/src/org/netbeans/modules/gradle/problems/PropertiesEditor.java
Show resolved
Hide resolved
extide/gradle/src/org/netbeans/modules/gradle/problems/PropertiesEditor.java
Show resolved
Hide resolved
lkishalmi
reviewed
Apr 29, 2022
| * @return files accessor. | ||
| * @since 2.24 | ||
| */ | ||
| public GradleFiles getFiles() { |
There was a problem hiding this comment.
Could the naming of the method be consistent and use getGradleFiles instead of getFiles?
lkishalmi
requested changes
Apr 29, 2022
Addressed in e1b89f8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy settings is one of the very unpleasant parts of Gradle: normal tools tend to honour environment variables, but Gradle knows better: only respects its own settings, either in the project, or in the
~/.gradle/gradle.properties.This PR processes
GradleReports produced after project (re)load. It detects some (not all!) typical situation - the number of matches may expand:IDE settings are used to 'autodetect' the valid proxy settings, I used a well-known root DNS
8.8.8.8that everyone should have route to.Gradle project offer fix that will alter the .properties file (project or user) that defines the proxies. If a proxy is not set up and the fix introduces one, it is always written into user properties file (~/.gradle/gradle.properties).