ide/lsp.client fonts-colors #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the lsp.client module acknoledge whatever font-colors have been registered for a given mimme-type. As a performance plus, the lookup of FontsAndColors is moved out of the loop over the tokens.getData() list.
Merged
|
Hi @matthiasblaesing , mind taking a look at this? These are the commits for |
ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
Outdated
Show resolved
Hide resolved
ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
Outdated
Show resolved
Hide resolved
ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
Outdated
Show resolved
Hide resolved
ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
Outdated
Show resolved
Hide resolved
ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/BreadcrumbsImpl.java
Outdated
Show resolved
Hide resolved
...nt/src/org/netbeans/modules/lsp/client/bindings/TextDocumentSyncServerCapabilityHandler.java
Outdated
Show resolved
Hide resolved
|
Thanks for the throrough review, @matthiasblaesing! |
vieiro
force-pushed
the
feature/lsp-coloring-threading
branch
from
af70600
to
e647625
Compare
vieiro
changed the title
matthiasblaesing
approved these changes
May 9, 2022
|
@matthiasblaesing yes, rearranging the threading is going to take longer than expected, worth a full PR in the future. Let's move along with cnd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ide/lsp.client threading and fonts-colors improvements