Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional fixes for Gradle reports #4067

Merged
merged 2 commits into from
May 5, 2022
Merged

Additional fixes for Gradle reports #4067

merged 2 commits into from
May 5, 2022

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented May 3, 2022

During testing of #4041, I've encountered issues that possibly affect NB14 - fixes are simple enough.

  • If `location' does not contain a proper path (it is a description, or e.g. a remote), Paths.get() or Path.relativize() may throw an exception
  • setting file locations are interpreted

@sdedic sdedic added kind:bug Bug report or fix Gradle [ci] enable "build tools" tests labels May 3, 2022
@sdedic sdedic added this to the NB14 milestone May 3, 2022
@sdedic sdedic requested review from ppisl and lkishalmi May 3, 2022 07:25
@sdedic sdedic self-assigned this May 3, 2022
lkishalmi
lkishalmi approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Please rebase this on the delivery branch if you wish to include this in NB14.

@sdedic sdedic changed the base branch from master to delivery May 4, 2022 07:44
@sdedic
Copy link
Member Author

sdedic commented May 4, 2022

Fine with me. Please rebase this on the delivery branch if you wish to include this in NB14.

Thanks ! Actually branched off from delivery, but I did not switch the target in PR web ...

@ebarboni ebarboni merged commit 0fa7be1 into apache:delivery May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkishalmi lkishalmi lkishalmi approved these changes

@ppisl ppisl Awaiting requested review from ppisl

Assignees

@sdedic sdedic

Labels
Gradle [ci] enable "build tools" tests kind:bug Bug report or fix
Projects
None yet
Milestone
NB14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdedic @lkishalmi @ebarboni