maven indexing: local repo indexing optimizations #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
force-pushed
the
local-indexing-performance
branch
2 times, most recently
from
7753ee9
to
646ff2c
Compare
vieiro
reviewed
May 10, 2022
java/maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java
Show resolved
Hide resolved
flamegraphs showed that ClassDependencyIndexCreator.addDependencyToMap had some potential for optimizations. - use stream instead of HashSet which gives a small perf improvement but also slightly more readable code - use simple startsWith() loop for prefix filtering instead of stateful impl (MatchWords), the JVM is likely very good at optimizing/vectorizing String intrinsics benchmark showed ~20% speedup
mbien
force-pushed
the
local-indexing-performance
branch
from
646ff2c
to
f8be12c
Compare
|
rebased to latest master so that its easier to test together with the latest fix #4136 |
There was a problem hiding this comment.
Looks good to me. I did a short test and can verify speedups in the promised ranged. Finding dependencies based on class name still worked.
I left a minimal nitpick inline. Not critical though, so feel free to apply or not.
Nice cleanup - shorter code, higher performance.
java/maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java
Show resolved
Hide resolved
matthiasblaesing
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flamegraphs showed that ClassDependencyIndexCreator.addDependencyToMap
had some potential for optimizations.
but also slightly more readable code IMO
stateful impl (MatchWords), the JVM is likely very good at
optimizing/vectorizing String intrinsics
benchmark showed ~20% speedup
full indexing takes on my system and with my current local maven repo ~53s (down from ~66s)
@timboudreau what is your opinion on this? You wrote most of the original optimizations (including the
MatchWordsclass). I can't see you in the reviewer list for some reason.sidenote:
I did also write a parallel version using an
ExecutorServicewhich could reduce it further to ~38s, but it made the code slightly more complex which is probably not worth the trouble. Parallelizing on a higher level (outside ofClassDependencyIndexCreator) might give better results (better scaling) since this is only a small slice of the task.flamegraphs:
