Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional methods into knownBLockingMethods to match classes of JDK-11 #4168

Merged
merged 1 commit into from May 30, 2022

Conversation

jtulach
Copy link
Contributor

@jtulach jtulach commented May 28, 2022

While investigating Enso parser performance I needed to filter out many idle threads. Rather than doing that manually I decided to update the knownBLockingMethods of NetBeans profiler.

Test with sample .npss file attached.

@jtulach jtulach added this to the NB15 milestone May 28, 2022
@jtulach jtulach self-assigned this May 28, 2022
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me - in the test the InputStream in loadSnapshot is not closed correctly, but that should not be a problem for a test.

@mbien
Copy link
Member

mbien commented May 29, 2022

even though it might not make a difference in practice, I believe it would be better to close that stream anyway, otherwise code scans will pick that up every time and it would add to the noise.

@jtulach jtulach merged commit ff09cf7 into apache:master May 30, 2022
@ebarboni
Copy link
Contributor

Sorry being late on this. I've recently splitted the netbeans-license job into two jobs the
netbeans-apisigcheck for sig test (that are always unstable)
netbeans-license to do basicaly the rat check verify-libs-and-licenses. so netbeans-license job should be green if we are good.

the npss is not handled so far, we should handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants