Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated col.toArray() java editor template ("2ar"). #4201

Merged
merged 1 commit into from Jun 10, 2022

Conversation

mbien
Copy link
Member

@mbien mbien commented Jun 6, 2022

old:

.toArray(new ${clazz}[${coll}.size()]);

new:

.toArray(new ${clazz}[0]);

see #3166 for details

would have been nice if the template would be able to conditionally generate the more modern version:

 .toArray(${clazz}[]::new);

old: .toArray(new ${clazz}[${coll}.size()]);
new: .toArray(new ${clazz}[0]);

see apache#3166 for details
@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Editor labels Jun 6, 2022
@mbien mbien added this to the NB15 milestone Jun 6, 2022
@mbien mbien requested a review from lkishalmi June 10, 2022 01:42
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial one. Approved!

@mbien mbien merged commit 42824e1 into apache:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants