-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Chrome DevTools Protocol for NodeJS Debugging #4220
Add support for Chrome DevTools Protocol for NodeJS Debugging #4220
Conversation
8c9b627
to
8ae5bad
Compare
Just a question, will this also work out of the box for TypeScript? |
I don't think so. The foundations could be used, but it needs to be integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is a pretty big one. I do not have JS knowledge to judge it. Also just skimmed through. Besides of the friend api-s there is nothing sore to my eyes.
As this one is a big one, I'd propose to merge early in the NB16 phase, so people could test it out,
Can we merge this one ? |
@matthiasblaesing we're getting close to freeze now, so need a call whether to merge for NB16, punt to NB17, or close. |
Moved to 17 - I'd like to have another look at this. |
8ae5bad
to
97c57b0
Compare
I intent to merge this by next week, so if anyone wants to object, please do so now. |
97c57b0
to
f4e4d62
Compare
I see no milestone but this PR looks ok. Could we make it for NB 22 ? |
The hit breakpoint is printed bold and the icon is marked with a small green arrow overlay.
f4e4d62
to
91431f6
Compare
This was tested and is reviewed. I rebased on master, gave it another mini-spin and if tests run clean, I plan to merge tomorrow. |
Highlight the hit breakpoint (see Marker in the "Breakpoints" Tab):
In the Global Node Configuration the debug protocol to be used can be selected, it defaults to the "Chrome DevTools protocol":
It would have been possible to select the protocol based on the version information from node, however the node from graalvm can't be safely and quickly detected, so the user has to choose.
In the per Project Settings the Node Debug Protocol can be overridden together with the node binary, as the two depend on each other: