Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chrome DevTools Protocol for NodeJS Debugging #4220

Merged

Conversation

matthiasblaesing
Copy link
Contributor

Highlight the hit breakpoint (see Marker in the "Breakpoints" Tab):

image

In the Global Node Configuration the debug protocol to be used can be selected, it defaults to the "Chrome DevTools protocol":

image

It would have been possible to select the protocol based on the version information from node, however the node from graalvm can't be safely and quickly detected, so the user has to choose.

In the per Project Settings the Node Debug Protocol can be overridden together with the node binary, as the two depend on each other:

image

@matthiasblaesing matthiasblaesing linked an issue Jun 11, 2022 that may be closed by this pull request
@matthiasblaesing matthiasblaesing added this to the NB15 milestone Jun 11, 2022
@matthiasblaesing matthiasblaesing added the JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor) label Jun 11, 2022
@matthiasblaesing matthiasblaesing force-pushed the chrome_devtools_protocol branch 2 times, most recently from 8c9b627 to 8ae5bad Compare June 12, 2022 08:46
@Chris2011
Copy link
Contributor

Just a question, will this also work out of the box for TypeScript?

@matthiasblaesing
Copy link
Contributor Author

Just a question, will this also work out of the box for TypeScript?

I don't think so. The foundations could be used, but it needs to be integrated.

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is a pretty big one. I do not have JS knowledge to judge it. Also just skimmed through. Besides of the friend api-s there is nothing sore to my eyes.

As this one is a big one, I'd propose to merge early in the NB16 phase, so people could test it out,

@ebarboni
Copy link
Contributor

ebarboni commented Oct 4, 2022

Can we merge this one ?

@neilcsmith-net
Copy link
Member

@matthiasblaesing we're getting close to freeze now, so need a call whether to merge for NB16, punt to NB17, or close.

@matthiasblaesing matthiasblaesing modified the milestones: NB16, NB17 Oct 11, 2022
@matthiasblaesing matthiasblaesing added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Oct 11, 2022
@matthiasblaesing
Copy link
Contributor Author

Moved to 17 - I'd like to have another look at this.

@matthiasblaesing matthiasblaesing removed this from the NB17 milestone Jan 5, 2023
@matthiasblaesing matthiasblaesing added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Oct 8, 2023
@matthiasblaesing
Copy link
Contributor Author

I intent to merge this by next week, so if anyone wants to object, please do so now.

@matthiasblaesing matthiasblaesing removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Nov 29, 2023
@ebarboni
Copy link
Contributor

ebarboni commented Apr 5, 2024

I see no milestone but this PR looks ok. Could we make it for NB 22 ?

@matthiasblaesing matthiasblaesing added this to the NB22 milestone Apr 14, 2024
@matthiasblaesing
Copy link
Contributor Author

This was tested and is reviewed. I rebased on master, gave it another mini-spin and if tests run clean, I plan to merge tomorrow.

@matthiasblaesing matthiasblaesing merged commit d20d7e4 into apache:master Apr 15, 2024
34 checks passed
@matthiasblaesing matthiasblaesing deleted the chrome_devtools_protocol branch April 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) JavaScript [ci] enable web job and extra JavaScript tests (webcommon/javascript2.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetBeans only supports obsolete node 6 debug protocol
6 participants