[NETBEANS-5599] PHP 8.1 Support: First class callable syntax #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://issues.apache.org/jira/browse/NETBEANS-5599 - https://wiki.php.net/rfc/first_class_callable_syntax - Fix the parser - Fix `PHP81UnhandledError` - Add unit tests
- https://issues.apache.org/jira/browse/NETBEANS-5599 - https://wiki.php.net/rfc/first_class_callable_syntax - Fix the GotoDeclaration and MarkOccurences - Add unit tests
- https://issues.apache.org/jira/browse/NETBEANS-5599 - https://wiki.php.net/rfc/first_class_callable_syntax - Add the HintError to check incorrect first-class callable syntax - Add unit tests
|
Probably, once this is merged, PHP 8.1 support is complete :) |
|
@tmysik Could you please have a look at this when you have time? If there is no problem, let's merge it. Thanks! |
tmysik
reviewed
Jun 19, 2022
php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCompletionItem.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Jun 19, 2022
php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCompletionItem.java
Show resolved
Hide resolved
tmysik
approved these changes
Jun 19, 2022
|
@junichi11 Junichi, please, let me know what you think about my nitpick comments. The change looks good to me, I am ready to merge. Thanks again for your great work! |
- https://issues.apache.org/jira/browse/NETBEANS-5599 - https://wiki.php.net/rfc/first_class_callable_syntax - Fix the code completion - Don't add callable(...) cc items by default - Add unit tests
junichi11
force-pushed
the
php81-first-class-callable-syntax
branch
from
7069e4d
to
34af956
Compare
|
@tmysik Fixed: https://github.com/apache/netbeans/compare/7069e4d2f2b90e385bc61681e1b8e4b37770bb24..34af956e74b9b92809cefdfd1126005d8ba35697 Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1
PHP81UnhandledErrorPHP 8.1
PHP 8.0
Part 2
Part 3
Part 4
Part 5