LSP: Auto import of types in code completion fixed. #4291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceUtils.resolveImport(...)
used to prevent clashes in import statements introduced by code completion.However, using of
SourceUtils.resolveImport(...)
has a side-effect: in addition torewrite(oldTree, newTree)
modifications, it also modifiesimportScopes
data structures (in order to work reliably if called repeatedly within a single task). Usually in NB, everyModificationTask
is followed bycommit()
onModificationResult
produced. This call changes the underlying document which invalidates the correspondingSource
, so it has to re-parsed for using in the next task (instead of using the cached parser result with corrupted scopes). However in NBLS, only diffs are taken from theModificationResult
and sent to client side for handling (without callingcommit()
). That is why the correspondingSource
has to be invalidated explicitly.