Adding symbol provider to obtain symbols for GoTo Symbol in workspace #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalek
requested changes
Jun 30, 2022
…out changes in the api.
|
I changed the implementation. Now the implementation does not require any API change. On the other hand, LSP Server depends on CSL API and CSL Types. |
IMHO dependency on CSL is not harmful, as CSL provides common infra for many languages (groovy included, 😉). |
dbalek
approved these changes
Jul 11, 2022
sdedic
approved these changes
Jul 11, 2022
| case KEYWORD: return SymbolKind.Key; | ||
| case OTHER: return SymbolKind.Object; | ||
| case PACKAGE: return SymbolKind.Package; | ||
| case PARAMETER: return SymbolKind.TypeParameter; |
There was a problem hiding this comment.
Maybe SymbolKind.Variable could be better ?
There was a problem hiding this comment.
Yes, it can be better. I will change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Go To Symbol functionality for Groovy source files in VSCode. Symbols are obtained from IndexSearcher (part of the CSL API). This implementation should only be temporary and should be replaced by a suitable API for retrieving symbols with lazy location, which may not return immediately, but only when the symbol is selected.