Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues in history view #4427

Merged
merged 1 commit into from Jul 25, 2022

Conversation

troizet
Copy link
Collaborator

@troizet troizet commented Jul 22, 2022

Hello! This PR fixes issues #4367 and #4394.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Seems to work too.

If you want to get this into NetBeans 15, you would have to put the commit on top of the delivery branch and then force push to this PR again. Master is for 16 already.

btw: I found another small issue while testing: if you select "Load All" it should probably remove the "Load next 30 days" item, since there shouldn't be anything more to load.

@neilcsmith-net neilcsmith-net added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 23, 2022
@neilcsmith-net neilcsmith-net added this to the NB15 milestone Jul 23, 2022
@neilcsmith-net
Copy link
Member

To help release tracking, have marked with NB15 and do-not-merge as and until the change in branch is made as suggested by @mbien

@troizet troizet changed the base branch from master to delivery July 24, 2022 04:19
@troizet
Copy link
Collaborator Author

troizet commented Jul 24, 2022

Implemented the suggested changes to the branch. @mbien, @neilcsmith-net please check if I did it right.

@troizet
Copy link
Collaborator Author

troizet commented Jul 24, 2022

@mbien, fixing the "Load All" issue, I think, is better done in another PR.

@mbien
Copy link
Member

mbien commented Jul 24, 2022

Implemented the suggested changes to the branch. @mbien, @neilcsmith-net please check if I did it right.

looks good, thanks for rebasing on delivery.

@neilcsmith-net neilcsmith-net removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 25, 2022
@neilcsmith-net neilcsmith-net merged commit f9b54f6 into apache:delivery Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Bug report or fix
Projects
None yet
3 participants