Some support for TOML files #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
reviewed
Aug 15, 2022
There was a problem hiding this comment.
awesome! We should use this PR as an up2date example of writing a language support module.
I quickly looked through it as first pass (no real review) and added two minor comments inline. Good job!
I think it would be good to have at least a basic "black box" test for this which parses a file and checks that nothing explodes.
ide/languages.toml/src/org/netbeans/modules/languages/toml/TomlLexer.java
Outdated
Show resolved
Hide resolved
|
As of tests, I still need to study the Yaml language support how to write them. There could be some edge cases in the keyboard handling and the code completion. |
|
Great work, will help me also to extend other languages and add more :) |
sdedic
reviewed
Aug 15, 2022
ide/languages.toml/src/org/netbeans/modules/languages/toml/LexerInputCharStream.java
Show resolved
Hide resolved
ide/languages.toml/src/org/netbeans/modules/languages/toml/TomlLexer.java
Outdated
Show resolved
Hide resolved
ide/languages.toml/src/org/netbeans/modules/languages/toml/layer.xml
Outdated
Show resolved
Hide resolved
ide/languages.toml/src/org/netbeans/modules/languages/toml/TomlCompletionProvider.java
Outdated
Show resolved
Hide resolved
| TokenHierarchy th = TokenHierarchy.get(doc); | ||
| TokenSequence<TomlTokenId> ts = th.tokenSequence(); | ||
| ts.move(offset); | ||
| ts.movePrevious(); |
There was a problem hiding this comment.
Maybe check the result of movePrevious; indicates end(begin)-of-token stream
ide/languages.toml/src/org/netbeans/modules/languages/toml/TomlTypedTextInterceptor.java
Outdated
Show resolved
Hide resolved
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
Dec 15, 2022
* Add tomlj library. * Added support for TOML Lexer * Added a few useful keystrokes for TOML * Added transparent backround to the TOML icon. * Added a simple TOML completion provider * Enabled TOML formatting options * Adjusted TOML Syntax Coloring * Remove some cruft on TOML Support * Polishing TOML Support * Added TOML Support to Editor Kit as dependency * Added some testing for TOML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This support provides the following: