Gradle hide empty generated folders #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
force-pushed
the
gradle-hide-empty-generated-folders
branch
from
a2358fe
to
8e4582e
Compare
sdedic
reviewed
Aug 27, 2022
| @@ -159,7 +160,7 @@ public synchronized SourceGroup[] getSourceGroups(String type) { | |||
| for (SourceType st : stype) { | |||
| Set<File> processed = new HashSet<>(); | |||
| for (String group : gradleSources.keySet()) { | |||
| Set<File> dirs = gradleSources.get(group).getSourceDirs(st); | |||
| Set<File> dirs = filterEmptyGeneratedDirs(gradleSources.get(group).getSourceDirs(st)); | |||
There was a problem hiding this comment.
Is it OK to filter the empty dirs from the data layer ? I'd rather leave them discoverable (as they are valid source roots), but filter them from the UI only.
There was a problem hiding this comment.
Good insight! Thanks! Moving it to the UI!
lkishalmi
force-pushed
the
gradle-hide-empty-generated-folders
branch
from
25b1a51
to
7ea9599
Compare
sdedic
approved these changes
Sep 1, 2022
| @@ -79,7 +97,8 @@ public List<SourceGroup> keys() { | |||
| ret.addAll(Arrays.asList(srcs.getSourceGroups(JavaProjectConstants.SOURCES_TYPE_JAVA))); | |||
| ret.addAll(Arrays.asList(srcs.getSourceGroups(GradleSourcesImpl.SOURCE_TYPE_KOTLIN))); | |||
| ret.addAll(Arrays.asList(srcs.getSourceGroups(JavaProjectConstants.SOURCES_TYPE_RESOURCES))); | |||
| ret.addAll(Arrays.asList(srcs.getSourceGroups(GradleSourcesImpl.SOURCE_TYPE_GENERATED))); | |||
| generatedGroups = Arrays.asList(srcs.getSourceGroups(GradleSourcesImpl.SOURCE_TYPE_GENERATED)); | |||
There was a problem hiding this comment.
nitpick: generatedGroups access is unsynchronized; here, the value should be assigned first to local, then to generatedGroups + added to ret, to be consistent (within this thread). generatedGroups could be possibly volatile
lkishalmi
force-pushed
the
gradle-hide-empty-generated-folders
branch
from
7ea9599
to
a049d85
Compare
BradWalker
pushed a commit
to BradWalker/netbeans
that referenced
this pull request
Sep 4, 2022
* Fix Gradle resourche watchers not attached on project open * Hide empty generated source dirs * Move the SourceGroup filtering to the UI Cleanup a bunch of raw type error msgs related to TreeSet.
BradWalker
pushed a commit
to BradWalker/netbeans
that referenced
this pull request
Sep 4, 2022
* Fix Gradle resourche watchers not attached on project open * Hide empty generated source dirs * Move the SourceGroup filtering to the UI Cleanup a bunch of raw type error msgs related to TreeSet.
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
Dec 15, 2022
* Fix Gradle resourche watchers not attached on project open * Hide empty generated source dirs * Move the SourceGroup filtering to the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When added the support of Generated source directories in Gradle project, the project view become a bit crowded, as the generated folders are always generated by Gradle.
Here there are two empty folder one for java and one for groovy.
Same project with the new code.
While implementing the change, I discovered a bug which prevented the freshly opened project to listen on resource changes. That one is the fist commit.