Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact tags, support for shaded output and source attachments. #4631

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Sep 13, 2022

This PR extends the still private API for project artifacts with 'tags', which are implementation- or technology-dependent labels. Currently tags are used to mark artifact that are 'shaded' (with dependencies included) or 'base' so the client can select processed or original artifacts.

Maven, for example, can produce multiple shaded artifacts with different classifiers or can replace the main project's artifact with the shaded one. Now the client is able to find or at least enumerate the originals, the shaded artifact and since they are tagged, the client can pick the files it needs.

Several abstract classifiers are defined (sources, test-sources, tests), they are mapped to build system's own classifiers by the implementation.

@sdedic sdedic added the Maven [ci] enable "build tools" tests label Sep 13, 2022
@sdedic sdedic requested a review from dbalek September 13, 2022 13:59
@sdedic sdedic self-assigned this Sep 13, 2022
Copy link
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@sdedic sdedic merged commit cb4112b into apache:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants