JavadocImports fixed for illegal string trim. #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fBoundsException.(apache#4646)
naotsugu
changed the title
mbien
added
kind:bug
matthiasblaesing
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Fix looks good to me. The code you removed looks like an initial implementation that was not cleared up after experimenting. I could reproduce the problem and verified, that the fix fixes it.
I checked the commit, the author information looks good.
@naotsugu I assume you read the license header and understand, that you donate the change to the ASF. If you don't agree, please indicate so, the changeset will be backed out then.
Once the final test job comes back green I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavadocImports fixed for illegal string trim raises a StringIndexOutOfBoundsException.(#4646)