Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible NPE while editing ANTLR Grammar #4662

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fix possible NPE while editing ANTLR Grammar #4662

merged 1 commit into from
Sep 22, 2022

Conversation

lkishalmi
Copy link
Contributor

Yes, it seems some things are still lurking. Let's start to patch them.

@lkishalmi lkishalmi added this to the NB16 milestone Sep 20, 2022
matthiasblaesing
matthiasblaesing approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guards look save. I left an inline question, but that is independent of this fix.

java/languages.antlr/src/org/netbeans/modules/languages/antlr/v4/Antlr4ParserResult.java Show resolved Hide resolved
@lkishalmi lkishalmi merged commit a1373cd into apache:master Sep 22, 2022
@mbien mbien added the ANTLR label Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
ANTLR
Projects
None yet
Milestone
NB16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lkishalmi @matthiasblaesing @mbien