Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to register Payara 6.x in Apache NetBeans 15 #4695

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

jGauravGupta
Copy link
Contributor

This PR adds Payara 6 configuration xml to enable registration of Payara Server 6.x in the Apache NetBeans IDE.

@jGauravGupta jGauravGupta added this to the NB16 milestone Sep 27, 2022
</java>
<javaee version="10.0.0">
<profile version="10.0.0" type="web"/>
<profile version="10.0.0" type="full" check="full"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks strange - previous version of payara declare support for multiple profiles - was that support never there or was it removed? (I compared with PayaraV5.xml).

I doubt this can be parsed, as the constants (version 10.0.0) are not defined in JavaEEProfile.java and it looks as if it should be. I assume this ties back into general EE support - is the support there yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthiasblaesing for reviewing the PR, I have set the 9.0.0 and 9.1.0 to Payara 6 profile and add the 10.0.0 version to Jakarta EE 10 support PR (WIP).

@matthiasblaesing
Copy link
Contributor

The test failures are expected (fix is currently being worked on), so if this was tested and works, I suggest that you squash these and get them in.

@jGauravGupta jGauravGupta merged commit 3a91f19 into apache:master Oct 10, 2022
Chris2011 pushed a commit to Chris2011/netbeans that referenced this pull request Dec 15, 2022
* Unable to register Payara 6.x in Apache NetBeans 15

* Set profile version to 9.1.0

* Add Jakarta EE 9.0.0 to profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants