Fix the syntax error for the constant array access #4684 #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the grammar file - Add unit tests
junichi11
force-pushed
the
gh-issue-4684-const-array-syntax-error
branch
from
4181555
to
ae7de61
Compare
|
It seems github actions did not pick up the PHP label. I'll try the "super secret" trick that was added (locking + unlocking this PR). Please don't be irritated. |
|
@tmysik Could you please have a look at this? If there is no problem, let's merge it :) Thanks! |
tmysik
approved these changes
Oct 7, 2022
|
@tmysik Thank you for your review! |
|
@junichi11 Nothing to thank for, really. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4684
Screenshot
Before:
After: