Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code completion after yield in switch expressions fixed. #4769

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Oct 11, 2022

Fixing code completion after typing yield in switch expressions.

@dbalek dbalek added this to the NB16 milestone Oct 11, 2022
@mbien
Copy link
Member

mbien commented Oct 11, 2022

please label PRs accordingly. This PR is not running the right tests.
https://lists.apache.org/thread/3gyc3xvxjjh8osh5rd6k81lshtno0j0z

the description mentions what tests are added for each label
https://github.com/apache/netbeans/labels?q=%5Bci%5D

@dbalek dbalek added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Oct 11, 2022
@mbien
Copy link
Member

mbien commented Oct 11, 2022

is this PR fixing the three failing testcases in java/java.completion org.netbeans.modules.java.completion.JavaCompletionTask117FeaturesTest under JDK 11+?

if yes, please sync again from master so that it contains the fix of #4756. After that, everything should be green again hopefully.

@neilcsmith-net

This comment was marked as off-topic.

@mbien

This comment was marked as off-topic.

@neilcsmith-net

This comment was marked as off-topic.

@mbien
Copy link
Member

mbien commented Oct 11, 2022

ok I am starting a fresh workflow run without a sync (please ignore lock conversation event, thats our secret restart button)

@apache apache locked and limited conversation to collaborators Oct 11, 2022
@apache apache unlocked this conversation Oct 11, 2022
@neilcsmith-net

This comment was marked as off-topic.

@mbien
Copy link
Member

mbien commented Oct 11, 2022

testCaseLabels 1,2,3 still failing, likely caused by #4746:

org.netbeans.junit.AssertionFileFailedError: Difference between /home/runner/work/netbeans/netbeans/java/java.completion/build/test/unit/work/o.n.m.j.c.J/cl/testCaseLabels_1.out and /home/runner/work/netbeans/netbeans/java/java.completion/build/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/AutoCompletion_CaseLabels_PatternMatchingSwitch_1.pass
diff: /home/runner/work/netbeans/netbeans/java/java.completion/build/test/unit/work/o.n.m.j.c.J/cl/testCaseLabels_1.diff
  at org.netbeans.junit.NbTestCase.assertFile(NbTestCase.java:742)
  at org.netbeans.junit.NbTestCase.assertFile(NbTestCase.java:792)
  at org.netbeans.modules.java.completion.CompletionTestBase.performTest(CompletionTestBase.java:110)
  at org.netbeans.modules.java.completion.JavaCompletionTask117FeaturesTest.testCaseLabels_1(JavaCompletionTask117FeaturesTest.java:55)
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77)
  at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476)
  at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402)
  at java.base/java.lang.Thread.run(Thread.java:829)

@dbalek dbalek merged commit 2662296 into apache:master Oct 12, 2022
@dbalek dbalek deleted the dbalek/cc-fixes branch October 12, 2022 12:47
Chris2011 pushed a commit to Chris2011/netbeans that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants