Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-4763] Handling switch expressions, case rules and exhaustive switches more correctly. #4788

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

jlahoda
Copy link
Contributor

@jlahoda jlahoda commented Oct 14, 2022


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

@jlahoda jlahoda added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Oct 14, 2022
@jlahoda jlahoda added this to the NB16 milestone Oct 14, 2022
@jlahoda jlahoda requested a review from sdedic October 14, 2022 05:44
@mbien mbien linked an issue Oct 14, 2022 that may be closed by this pull request
@neilcsmith-net
Copy link
Member

@sdedic @jtulach would be good if either/both of you could take a look, confirm the fix and merge before freeze.

@neilcsmith-net neilcsmith-net modified the milestones: NB16, NB17 Oct 19, 2022
@mbien
Copy link
Member

mbien commented Dec 30, 2022

this looks ready to merge to me, tests are green too. @jlahoda @matthiasblaesing should we get this in?

@matthiasblaesing
Copy link
Contributor

@mbien I saw this yesterday and I agree. I ran test tonight and locally I saw failures, but these were timeouts and language depedneded problems. The corresponding tests were ran on the github actions infrastructure and there they worked. So yes this should go in.

@mbien
Copy link
Member

mbien commented Dec 31, 2022

going to risk it and merge. java.hints batch1 and batch2 ran on CI and this particular test does also run locally for me (started with IDE, even on JDK 19).

@mbien mbien added kind:bug Bug report or fix hints labels Dec 31, 2022
@mbien mbien merged commit 604cf9d into apache:master Dec 31, 2022
@jlahoda
Copy link
Contributor Author

jlahoda commented Dec 31, 2022

Thanks for merging - I don't see a reason why not!

@mbien
Copy link
Member

mbien commented Dec 31, 2022

Thanks for merging - I don't see a reason why not!

We are always a bit careful with reviewed PRs which didn't have their tests run for a long time. It happened before that it broke master which isn't a huge problem since it can be fixed again but it still is annoying so we try to avoid it if possible.

The problem here is that travis is now gone but was still there when this PR ran, so to run the tests again someone would have to push into this PR and rebase. Since this is a small PR and is easy to check I think its fine to simply merge it without the extra steps (master is green so everything is looking good so far :)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hints Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) kind:bug Bug report or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect method will recurse indifinitely hint
5 participants