NBABasedBulkSearch::encode doesn't return on cancel #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
sdedic
approved these changes
Oct 25, 2022
|
@sdedic thanks for taking a look. I also thought that this was fairly low risk - most likely a (minor) copy&paste bug Brad discovered in his cleanup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BradWalker found in #4781 a minor bug where
cancel.get()was checked but ignored.The last check is redundant since it is the end of the method.
This might have been a copy and paste bug, since other methods have checks like
if (cancel.get) return null;. I suppose it was meant to only remove thenullbut leave thereturn