Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup more raw type List warnings.. #4794

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

BradWalker
Copy link
Member

Cleanup more raw type List warnings that look like this:

[repeat] /home/bwalker/src/netbeans/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/client/ClientDataObject.java:174: warning: [rawtypes] found raw type: List
[repeat] java.util.List changes = null;
[repeat] ^
[repeat] missing type arguments for generic class List
[repeat] where E is a type-variable:
[repeat] E extends Object declared in interface List


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

@BradWalker BradWalker added API Change [ci] enable extra API related tests Code cleanup labels Oct 15, 2022
@BradWalker BradWalker added this to the NB17 milestone Oct 15, 2022
@BradWalker BradWalker self-assigned this Oct 15, 2022
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane - I left two inline comments. In the profile modules there might be the opportunity to use ? extends TreePath in some of the cases, but I doubt that there are subclasses from TreePath explicitly used.

Cleanup more raw type List warnings that look like this:

   [repeat] /home/bwalker/src/netbeans/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/client/ClientDataObject.java:174: warning: [rawtypes] found raw type: List
   [repeat]                     java.util.List changes = null;
   [repeat]                              ^
   [repeat]   missing type arguments for generic class List<E>
   [repeat]   where E is a type-variable:
   [repeat]     E extends Object declared in interface List

Also, removed ComplexValueSettingsFactory as it's not exported and unused in the module.
@BradWalker BradWalker merged commit ee5492d into apache:master Oct 16, 2022
@BradWalker BradWalker deleted the cleanup_raw_type_List branch October 16, 2022 23:30
@ebarboni ebarboni modified the milestones: NB17, NB16 Oct 17, 2022
Chris2011 pushed a commit to Chris2011/netbeans that referenced this pull request Dec 15, 2022
Cleanup more raw type List warnings that look like this:

   [repeat] /home/bwalker/src/netbeans/enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/client/ClientDataObject.java:174: warning: [rawtypes] found raw type: List
   [repeat]                     java.util.List changes = null;
   [repeat]                              ^
   [repeat]   missing type arguments for generic class List<E>
   [repeat]   where E is a type-variable:
   [repeat]     E extends Object declared in interface List

Also, removed ComplexValueSettingsFactory as it's not exported and unused in the module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change [ci] enable extra API related tests Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants