Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update asm from 9.3 to 9.4 #4820

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Update asm from 9.3 to 9.4 #4820

merged 1 commit into from
Dec 8, 2022

Conversation

pepness
Copy link
Member

@pepness pepness commented Oct 19, 2022

Library Notes:

  • JDK 20 support
  • more checks in CheckClassAdapter
  • Javadoc improvements and fixes
  • module-info classes can be built without Gradle and Bnd
  • parent POM updated to org.ow2:ow2:1.5.1
  • Bug fixes
    • 317977: CheckClassAdapter is no longer transparent for MAXLOCALS
    • 317981: Add public getDelegate method to all visitor classes
    • Analyzer does not compute optimal maxLocals for static methods
    • Fix SignatureWriter when a generic type has a depth over 30
    • Skip remap inner class name if not changed in Remapper

Testing:

  • Full build done
  • Verify successful execution of libraries and licenses Ant test

ASM Web Page
Release Notes

@pepness pepness added the Upgrade Library Library (Dependency) Upgrade label Oct 19, 2022
@pepness pepness added this to the NB17 milestone Oct 19, 2022
@pepness pepness self-assigned this Oct 19, 2022
@mbien mbien added Platform [ci] enable platform tests (platform/*) ci:all-tests [ci] enable all tests labels Oct 20, 2022
@mbien
Copy link
Member

mbien commented Oct 20, 2022

since its a platform lib we have to put the Platform label on this otherwise the tests won't run, but just to be sure: added ci:all-tests since its core functionality. Restarting CI.

@apache apache locked and limited conversation to collaborators Oct 20, 2022
@apache apache unlocked this conversation Oct 20, 2022
matthiasblaesing
matthiasblaesing approved these changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an API perspective this looks save. I ran both libraries through japi-compliance-checker and japicmp and there are only minimal API additions (the *Visitor classes learned a new method getDelegate).

@mbien
Copy link
Member

mbien commented Dec 8, 2022

looks good, lets get this in too

@mbien mbien merged commit e2815e6 into apache:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@lkishalmi lkishalmi Awaiting requested review from lkishalmi

Assignees

@pepness pepness

Labels
ci:all-tests [ci] enable all tests Platform [ci] enable platform tests (platform/*) Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pepness @mbien @matthiasblaesing