More options for LSP audit command #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
VSCode Extension
sdedic
force-pushed
the
vscode/project-audit-options
branch
from
84455cf
to
83325a0
Compare
|
Rebased on |
|
cc @MartinBalin for review and merge. I've retriggered the failing Travis test. |
MartinBalin
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up parmeters passed to LSP display and execute: since
knowledgeBaseis required, thecompartmentis not needed, can be derived fromknowledgeBase.In addition a requested
auditNamecan be passed to the LSP command in case an audit is to be created (either display + force, or execute). Otherwise some default name is made up by the impl.The PR will be eventually rebased on
delivery