Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven UseReleaseOptionHint fixes #4835

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 21, 2022

follow up on #4802

  • NPE fix when build tag is empty
  • don't show hint if there is no compiler plugin in the pom
  • simplified code, added more tests

targets delivery

 - NPE fix when build tag is empty
 - don't show hint if there is no compiler plugin in the pom
 - simplified code, added more tests
@mbien mbien added kind:bug Bug report or fix Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests labels Oct 21, 2022
@mbien mbien added this to the NB16 milestone Oct 21, 2022
@neilcsmith-net neilcsmith-net merged commit 61aafaa into apache:delivery Oct 24, 2022
@mbien
Copy link
Member Author

mbien commented Oct 24, 2022

sorry, forgot to ping for reviewers. Willing to fix issues asap if this causes problems.

@neilcsmith-net
Copy link
Member

Problem with 2 (no compiler plugin) is it now doesn't show in the default created POM. That might be something to address in master though? In fact, probably the whole default POM needs some consideration.

@mbien
Copy link
Member Author

mbien commented Oct 25, 2022

The hint can't show with the default POM because the default compiler plugin in use without setting it would be < 3.6. So it would complain about not knowing what the release flag is during build. I overlooked this detail at first too.

(for the same reason we can't update the pom template unless we also add the compiler plugin by default)

@neilcsmith-net
Copy link
Member

Yes, I understand that. Would need to link to code like that which detects module-info possibly? But I think we probably do need a better starter POM template.

Anyway, I think this is good for NB16. I did do a quick review over before merging!

@mbien
Copy link
Member Author

mbien commented Oct 25, 2022

But I think we probably do need a better starter POM template.

I thought about a JDK selector in the new-project-wizard. If a modern JDK is selected it would use a template which has a compiler plugin declaration and the right release option set for the selected JDK. (project would have that JDK also pre selected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) kind:bug Bug report or fix Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants