Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put nb-javac modules on the plugin import block list. #4838

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 21, 2022

Users which import nb-javac plugins from old NB versions complain about not being able to start NB anymore (most recent: #4799). This puts all nbjavac modules which were in NB 12.1 on the block list and will hopefully prevent this in future.

targets delivery

Users which import nb-javac plugins from old NB versions complain
about not being able to start NB anymore. This puts all nbjavac modules
which were in NB 12.1 on the block list.
@mbien mbien added kind:bug Bug report or fix Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) labels Oct 21, 2022
@mbien mbien added this to the NB16 milestone Oct 21, 2022
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks! Should have been done when we first pre-bundled again.

@lkishalmi
Copy link
Contributor

Cool, I did not know we have such a feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) kind:bug Bug report or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants