Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4847: do not use newer classes in older distributions. #4850

Merged
merged 1 commit into from
Oct 25, 2022
Merged

#4847: do not use newer classes in older distributions. #4850

merged 1 commit into from
Oct 25, 2022

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Oct 24, 2022

I've added version guards to the newer introspection entry points. Also added tests that ensure a basic project will load in 6.8.3, 7.0 and 7.1 gradles.

@sdedic sdedic added kind:bug Bug report or fix Gradle [ci] enable "build tools" tests labels Oct 24, 2022
@sdedic sdedic added this to the NB16 milestone Oct 24, 2022
@sdedic sdedic requested a review from lkishalmi October 24, 2022 17:43
@sdedic sdedic self-assigned this Oct 24, 2022
@sdedic sdedic linked an issue Oct 24, 2022 that may be closed by this pull request
Gradle won't load project in NetBeans-16rc1 #4847
Closed
lkishalmi
lkishalmi approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sdedic sdedic added the priority:high High priority issue that should, if possible, be fixed in next release label Oct 25, 2022
@MartinBalin MartinBalin self-requested a review October 25, 2022 08:07
@MartinBalin MartinBalin merged commit 83da184 into apache:delivery Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkishalmi lkishalmi lkishalmi approved these changes

@MartinBalin MartinBalin Awaiting requested review from MartinBalin

Assignees

@sdedic sdedic

Labels
Gradle [ci] enable "build tools" tests kind:bug Bug report or fix priority:high High priority issue that should, if possible, be fixed in next release
Projects
None yet
Milestone
NB16
Development

Successfully merging this pull request may close these issues.

Gradle won't load project in NetBeans-16rc1
3 participants
@sdedic @lkishalmi @MartinBalin