about panel needs a vertical scrollbar if the async plugin update notification appears #4877
Conversation
notification appears. we can't add it right away, otherwise the window can't layout itself.
|
@neilcsmith-net this is a minor low risk bug fix for delivery.
enables the scrollbar if the "Updates:" text appears. |
|
@mbien already seen and on the radar. Looks good, makes sense. Thanks! |
| @@ -102,6 +103,7 @@ public ProductInformationPanel() { | |||
| final String updates = getUpdates(); | |||
| SwingUtilities.invokeLater(() -> { | |||
| description.setText(LBL_description(getProductVersionValue(), getJavaValue(), getVMValue(), getOperatingSystemValue(), getEncodingValue(), getSystemLocaleValue(), getUserDirValue(), Places.getCacheDirectory().getAbsolutePath(), updates, FONT_SIZE, getJavaRuntime())); | |||
| descriptionScrollPane.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS); // will need a scrollbar now | |||
There was a problem hiding this comment.
It's not clear to me what now is referring to in the comment.
There was a problem hiding this comment.
the moment the description text is updated. Which is what the lambda does. So at the point in time this lambda runs. Now basically.
There was a problem hiding this comment.
Thanks, I was confused by the title ".... scrollbar if the async plugin update..." but it's a little more like
"... scrollbar in case the async plugin update...".
I had thought it might mean now that there are updates available.
So the scrollbar is there, even when there are no updates available.
fixes #4876
we can't add it right away, otherwise the window can't layout itself without hardcoding the size of the scrollpane. Changing window size once its visible would look weird.
targets delivery