Fixed end of file indenting and code completion for ANTLR v4 #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lkishalmi we aim to have at least 3 release candidates, so 16-rc3 is happening. Have retriggered the failing tests (failure in binary downloads so not related to changes). I'll wait for @matthiasblaesing review. |
matthiasblaesing
approved these changes
Oct 29, 2022
|
@neilcsmith-net Thanks for the merge! @matthiasblaesing I've tried to solve this indenting issue, but that got too convoluted, and caused other issues. I fear I have to rewrite the formatting code for that. So far what that's just heuristics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, if we would have a 16-rc3 this would be a nice to have.
This one makes the formatting work if the editing happens at the end of the file.
The code completion has a fix and a feature creep. At the end of the file due to the bug in
AntlrTokenSequenceit was offering (lexer,parser,grammar).The feature creep is a trivial one. We already have the unknown references collected during parsing, so why not offer to define those while not in a rule definition.