Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 Support: Allow null, false, and true as stand-alone types #4888

Conversation

junichi11
Copy link
Member

#4725

Add PHP 8.2 to the PhpVersion

nb-php82-php-version-for-project-properties

Allow null and false as stand-alone types

nb-php82-null-and-false-as-stand-alone-types

Add true type

nb-php82-add-true-type-hint-errors

nb-php82-add-true-type-navigator

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Oct 30, 2022
@junichi11 junichi11 added this to the NB17 milestone Oct 30, 2022
@junichi11 junichi11 requested a review from tmysik October 30, 2022 07:35
@junichi11
Copy link
Member Author

junichi11 commented Oct 30, 2022

@tmysik Could you please have a look at this? If there is no problem, let's merge it. Thanks!

Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for all the tests.

@tmysik tmysik merged commit ebb361e into apache:php82-support Oct 30, 2022
@junichi11
Copy link
Member Author

@tmysik Thank you for your review!

@junichi11 junichi11 deleted the php82-allow-nul-and-false-and-true-as-stand-alone-types branch October 30, 2022 10:43
@junichi11 junichi11 added the hacktoberfest-accepted Hacktoberfest label Oct 30, 2022
@junichi11 junichi11 mentioned this pull request Nov 10, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants