Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Abandoned Cache Dirs Automatically [Janitor] #4900

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

lkishalmi
Copy link
Contributor

This one adds an option to the Janitor to remove abandoned cache directories automatically.

Well, I've set the default true, as even this is a delete operation. it is just cache. Usually it bothers me, as a user of netbeans-dev Snap package, which is updated weekly and leaves a cache directory behind each week.

@lkishalmi lkishalmi added the Platform [ci] enable platform tests (platform/*) label Nov 2, 2022
@lkishalmi lkishalmi added this to the NB17 milestone Nov 2, 2022
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me and removing cache dirs should always be harmless.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean code and clean caches!

I also think that its fine to auto remove caches which are older than 30 days. This hopefully shouldn't impact users which use multiple IDE versions at the same time. Maven index is getting big, good that NB has a janitor.

@lkishalmi lkishalmi merged commit ccfa084 into apache:master Nov 10, 2022
@lkishalmi lkishalmi deleted the janitor-auto-remove-cache branch November 10, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform [ci] enable platform tests (platform/*)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants