Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java.editor tests #4931

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Fix java.editor tests #4931

merged 4 commits into from
Nov 8, 2022

Conversation

jlahoda
Copy link
Contributor

@jlahoda jlahoda commented Nov 6, 2022

This patch fixes various problems so that java.editor unit tests pass on JDK 8 and 11, and adds the tests into the GitHub Action configuration.


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

@jlahoda jlahoda added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Nov 6, 2022
@jlahoda jlahoda added this to the NB17 milestone Nov 6, 2022
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! Good to have the java.editor tests running again.

Copy link
Contributor

@singh-akhilesh singh-akhilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbien
Copy link
Member

mbien commented Nov 8, 2022

all green, two approvals -> merging, since the more editor tests we have active the better.

@mbien mbien merged commit ad32eef into apache:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants