bump large file warning from 1 to 5MB. #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Editor
Platform
|
This is long overdue.. I might have even said bump to 10MB. But, I approve.. |
BradWalker
approved these changes
Nov 9, 2022
mbien
force-pushed
the
defaults-bump-file-size-warn-limit
branch
from
3276fa2
to
4a0f97c
Compare
yeah. I wasn't sure what new limit to pick. Some editors might want the warning a bit lower, e.g a 10MB javascrip file might be too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed on the dev list, this proposes to bump the large-file warning trigger a little bit.
customizable via the
org.openide.text.big.file.sizeproperty.System memory and there also heap sizes grew over time, fixed perm gen became dynamic meta space. This should allow to dare a bit more in that area without showing warnings.
old limit (new is 5MB):
going to run this with all tests enabled since this could have side effects in tests, given that I found that CSL module hardcoded that value even though it is configurable via a property.