PHP 8.2 Support: Readonly classes #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmysik Could you please have a look at this when you have time? If there is no problem, let's merge it :) Thanks! |
|
@tmysik Will increment the spec version. |
- apache#4725 - https://wiki.php.net/rfc/readonly_classes - Fix the grammar file - Add `PHP82UnhandledError` - Add/Fix unit tests for the parser, the lexter, and the index
- apache#4725 - https://wiki.php.net/rfc/readonly_classes - Fix hints for readonly classes - Add the code template for a readonly class - Add unit tests for hints, formatter, and CC
junichi11
force-pushed
the
php82-readonly-classes
branch
from
b8265cf
to
e4286d6
Compare
tmysik
reviewed
Nov 10, 2022
php/php.editor/src/org/netbeans/modules/php/editor/model/nodes/ClassDeclarationInfo.java
Show resolved
Hide resolved
tmysik
approved these changes
Nov 10, 2022
|
@tmysik Thank you for your review! I'll fix it with the next PR. |
|
@junichi11 Nothing to thank for, really. Plenty of tests really help us here. Thanks for your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4725
Part 1
PHP82UnhandledErrorPart 2