Avoid an AssertionError with Maven folds
#4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
restarting tests so that they pick up the label using our super secret restart button. edit: glad to see someone using mvnd with NetBeans :) |
Other than this issue, it works well! (Almost a satisfactory replacement for compile-on-save, unless you have snapshot dependencies on other projects you are actively editing.) For large multimodule reactors I prefer to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3675 by just disabling output window folds when they would otherwise lead to errors and loss of output. Observed when using
mvndwith forked executions in a multimodule build. (The same project gets folds when building one module at a time, or usingmvn, and probably also when skipping the mojo causing a forked execution though I did not manage to test that.)